Fullscreen wai ?

Discussion in 'Bugs' started by Phaselock, May 27, 2013.

  1. Phaselock

    Phaselock Bugblatter

    [​IMG]

    Is anyone else experiencing this upon login ? I'm getting this everytime I login, post 2.16 build. Refreshing the browser doesn't help, neither does closing and re-opening it. Latest ffox.
     
  2. Jon

    Jon Blue Manchu Staff Member

    That's Flash. I'm surprised you only just started seeing that.
     
  3. Phaselock

    Phaselock Bugblatter

    I had no idea clicking on 'play' button to log in triggers the full screen UI. :confused:
    Never happened to me prior 2.16...personally, its a hassle. Cos its now 2 buttons I have to click. :p
     
  4. Jon

    Jon Blue Manchu Staff Member

    Woah. What happens if you toggle fullscreen off before logging out?
     
    Sam Ferdinand likes this.
  5. Phaselock

    Phaselock Bugblatter

    ok, I figured out the problem. Its reproducible and consistent. Steps:

    a) Normal login: login should not show fullscreen options and I'm not in fullscreen mode either.
    b) Click Campaign -> menu -> Toggle Fullscreen -> press Esc (Don't click cancel/allow) -> click Back.
    c) Refresh browser and relog, all future logins (irrespective of browser refresh/reboot) will prompt for fullscreen options.

    wai ?
     
  6. Farbs

    Farbs Blue Manchu Staff Member

    It sounds like we might be fouling up saving the full screen option somewhere.

    As an aside, the reason we apply your fullscreen preferences on login is that flash only allows us to set fullscreen in response to an input event. Otherwise adverts could go fullscreen on you whenever they wanted, which would be super annoying.
     
  7. Phaselock

    Phaselock Bugblatter

    If I do this:

    a) Normal login: login should not show fullscreen options and I'm not in fullscreen mode either.
    b) Click Campaign -> menu -> Toggle Fullscreen -> click Back -> click fullscreen icon in top right hand corner to dismiss options.
    c) Refresh browser and relog. It does not prompt for fullscreen options.

    Seems like full screen save var is not recognizing 'esc' button. It assumes I'm still in fullscreen option mode and triggers everytime on relog. Hope it helps.
     
  8. Jon

    Jon Blue Manchu Staff Member

    I think what's happening is that we save the full screen setting when you click the full screen button. If you then cancel the full screen operation, it's too late - we try to restore full screen each time you login.

    Do you agree?
     
  9. Phaselock

    Phaselock Bugblatter

    If by 'full screen button', you mean the in menu 'toggle fullscreen' button ... then yes. Because, the top right hand fullscreen icon button is operating fine. I fail to understand why it's too late, it feels more like a preference setting than a toggle.
     
  10. Farbs

    Farbs Blue Manchu Staff Member

    Esc to cancel fullscreen is another flash thing, not a code path we wrote ourselves. We probably just need to detect it (hopefully by some kind of fullscreen event, rather than tooling about with the resize event) and respond accordingly.
     
  11. Phaselock

    Phaselock Bugblatter

    I just tested esc, ctrl-w and alt-f4 against the in menu toggle and the top right single button toggle. Only the in menu toggle is misbehaving consistently for all 3 cases. I'm guessing an event listener is missing somewhere. hope it helps. :)
     

Share This Page